Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @metamask/json-rpc-engine #275

Closed
wants to merge 6 commits into from
Closed

Use @metamask/json-rpc-engine #275

wants to merge 6 commits into from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Aug 24, 2023 •
edited
Loading

@legobeat
Copy link
Contributor Author

legobeat commented Aug 24, 2023 •
edited
Loading

This happens regardless of if bumping @metamask/utils or not:

https://github.com/MetaMask/providers/actions/runs/5958076982/job/16161797970
https://github.com/MetaMask/providers/actions/runs/5959652471/job/16165741468?pr=275

Error: src/utils.ts(51,7): error TS2322: Type 'JsonRpcError<JsonRpcRequest<Json[] | Record<string, Json> | undefined>>' is not assignable to type '{ code: number; message: string; data?: Json | undefined; stack?: string | undefined; }'.
  Types of property 'data' are incompatible.
    Type 'JsonRpcRequest<Json[] | Record<string, Json> | undefined>' is not assignable to type 'Json | undefined'.
      Type 'JsonRpcRequest<Json[] | Record<string, Json> | undefined>' is not assignable to type '{ [prop: string]: Json; }'.
        Property 'params' is incompatible with index signature.
          Type 'Json[] | Record<string, Json> | undefined' is not assignable to type 'Json'.
            Type 'undefined' is not assignable to type 'Json'.
Error: Process completed with exit code 2.

Attempt at fix: MetaMask/utils#130
Validation of fix: #276

@legobeat legobeat mentioned this pull request Aug 24, 2023
Closed
@legobeat
Copy link
Contributor Author

legobeat commented Sep 1, 2023

#277

@legobeat legobeat closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @FrederikBolding